Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Slider Header" option in CBOX Theme Options page does not work #113

Closed
r-a-y opened this issue Jan 19, 2013 · 10 comments
Closed

"Slider Header" option in CBOX Theme Options page does not work #113

r-a-y opened this issue Jan 19, 2013 · 10 comments

Comments

@r-a-y
Copy link
Member

r-a-y commented Jan 19, 2013

Received a report that the Slider Header option listed on the CBOX Theme Options page under "Options > Homepage > Slider Setup" does not work:
http://commonsinabox.org/groups/help-support/forum/topic/register-page/#post-1700

I've confirmed that this is the case.

A potential solution involves adding a code snippet to the end of /engine/includes/feature-slider/template.php:

<?php
// Slider header option
echo apply_filters( 'the_content', infinity_option_get( 'cbox_flex_slider_title' ) );
?>

@BoweFrankema - Let me know if you're okay with adding this code snippet there.

@BoweFrankema
Copy link
Collaborator

Sure thing :-)

On Jan 19, 2013, at 1:52, r-a-y notifications@github.com wrote:

Received a report that the Slider Header option listed on the CBOX Theme
Options page under "Options > Homepage > Slider Setup" does not work:
http://commonsinabox.org/groups/help-support/forum/topic/register-page/#post-1700

I've confirmed that this is the case.

A potential solution involves adding a code snippet to the end of
/engine/includes/feature-slider/template.php:

@BoweFrankema https://github.com/BoweFrankema - Let me know if you're
okay with adding this code snippet there.


Reply to this email directly or view it on
GitHubhttps://github.com//issues/113.

@BoweFrankema
Copy link
Collaborator

I'll commit the changes for this tomorrow!

@boonebgorges
Copy link
Member

Hey @BoweFrankema - Ping on this one. It looks like Ray's suggested fix does work, but wanted to check in with you to make sure it's the right approach before moving any further. Thanks!

@BoweFrankema
Copy link
Collaborator

I'd like to remove this option all together. It's a left over option that slipped through the cracks from a project where I needed that option. In the current design a callout text below the slider is not needed, because we have the widget space on the right of the slider for that. So my suggestion is to remove the option entirely. Agreed @r-a-y and @boonebgorges ?

@r-a-y
Copy link
Member Author

r-a-y commented Aug 1, 2013

If we are removing a feature (even if it didn't work), we'll have to inform the community.

There were a few support questions on cbox.org asking for this, so the fact that people attempted to use it means we should address it?

@boonebgorges
Copy link
Member

If there's another way to accomplish the same effect (as Bowe says, there is a widget area there now), and if the feature is currently broken, then I think we can safely remove the feature - it won't be taking anything real away, and no one will have their site changed when it goes missing.

Those are two "if"s though. Are we sure that the feature is currently working for no one?

@r-a-y
Copy link
Member Author

r-a-y commented Aug 1, 2013

Actually, now that Boone enlightened me, we do have a "Homepage Center Widget" area, which is pretty much the same thing and is more flexible.

Agreed with everybody. Let's close this one!

@r-a-y r-a-y closed this as completed Aug 1, 2013
@r-a-y
Copy link
Member Author

r-a-y commented Aug 1, 2013

Actually, I'm going to reopen this as we still have to remove the feature itself.

@AweVision7
Copy link

It appears that the option to include "Freeform Text" under the slider has been removed, because its control at “Appearance>>CBOX Theme Options>>Home Page>>Slider Header” is not available (probably removed due to the previous comments above).

If so, can someone also please remove the "Freeform Text" image and its description from the tutorial at http://commonsinabox.org/documentation/cbox-slider ?

This would help to remove any confusion to newbies like myself.

Thank you.

@r-a-y
Copy link
Member Author

r-a-y commented Sep 30, 2018

@AweVision7 - Thanks for finding this discrepancy with our documentation. I've just updated the image and documentation page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants